Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the missing update when dependency in kcl.mod and kcl.mod.lo… #225

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: fix the missing update when dependency in kcl.mod and kcl.mod.lo… #225

merged 1 commit into from
Dec 13, 2023

Conversation

zong-zhe
Copy link
Contributor

…ck has different version

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #224

2. What is the scope of this PR (e.g. component or file name):

kpm update

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Dec 12, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy December 12, 2023 13:12
@zong-zhe zong-zhe self-assigned this Dec 12, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7181968709

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 36.308%

Totals Coverage Status
Change from base Build 7086471762: 0.09%
Covered Lines: 1310
Relevant Lines: 3608

💛 - Coveralls

@zong-zhe zong-zhe merged commit c61ffdb into kcl-lang:main Dec 13, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: v0.7.0 Release Done
3 participants