Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added design doc for sparse checkout #335
added design doc for sparse checkout #335
Changes from all commits
733adb9
6352f5b
a52c590
f4e65e2
3927f04
f113f09
d7da73d
8b66da9
cb6d79d
0192fc0
f99daee
2e83c64
4de7d69
19667bd
87c62be
5247cb1
8c768c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more details, including what happens if
--package
is not added, since--package
is an option flag, and updates inkcl.mod
andkcl.mod.lock
after running.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature won't work without a package flag. Should i specify that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can not do an incomplete function for the user. You need to consider the user's various situations, and make corresponding preparations. For example, you should at least design that when he does not give this field or gives this field,
kcl mod add
works normally or does not work normally, what doeskcl.mod
,kcl.mod.lock
, and the corresponding CLI output should look like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated accordingly. Can you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/
kcl mod run
/kcl run