Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing Print() #428

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: fix missing Print() #428

merged 1 commit into from
Aug 2, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Aug 2, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #kcl-lang/kcl#1535

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Aug 2, 2024
@zong-zhe zong-zhe requested a review from Peefy August 2, 2024 09:51
@zong-zhe zong-zhe self-assigned this Aug 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10213605447

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 40.289%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/run.go 5 7 71.43%
Totals Coverage Status
Change from base Build 10198962112: 0.03%
Covered Lines: 3126
Relevant Lines: 7759

💛 - Coveralls

@Peefy Peefy merged commit 2b1e0b9 into kcl-lang:main Aug 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants