Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing tag in command push #561

Merged
merged 10 commits into from
Dec 4, 2024
Prev Previous commit
fix: fix windows test case
Signed-off-by: zongz <zongzhe1024@163.com>
  • Loading branch information
zong-zhe committed Dec 4, 2024
commit 67662acd5c309129e6419d9ddc2fe86cbf0f2880
4 changes: 3 additions & 1 deletion pkg/client/issues_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ func TestKpmIssue226(t *testing.T) {
func TestKclIssue1768(t *testing.T) {
testPath := "github.com/kcl-lang/kcl/issues/1768"
test_push_with_tag := func(t *testing.T, kpmcli *KpmClient) {

if runtime.GOOS == "windows" {
t.Skip("Skipping test on Windows")
}
err := mock.StartDockerRegistry()
if err != nil {
t.Errorf("Error starting docker registry: %v", err)
Expand Down
4 changes: 4 additions & 0 deletions pkg/client/push_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package client
import (
"bytes"
"path/filepath"
"runtime"
"testing"

"github.com/stretchr/testify/assert"
Expand All @@ -14,6 +15,9 @@ import (

func TestPush(t *testing.T) {
testFunc := func(t *testing.T, kpmcli *KpmClient) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test on Windows")
}
err := mock.StartDockerRegistry()
if err != nil {
t.Errorf("Error starting docker registry: %v", err)
Expand Down
Loading