Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlc: add support for 'sql_driver' go gen option #229

Merged

Conversation

YvanDaSilva
Copy link
Contributor

sqlc lacks documentation on sql_driver setting
however setting is referenced in multiple places in their documentation the inputs and validation was done based on the latest sqlc code v1.27.0

See the following issue created in sqlc repo:

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

  • Email:
  • HomePage:

sqlc lacks documentation on sql_driver setting
however setting is referenced in multiple places in their documentation
the inputs and validation was done based on the latest sqlc code v1.27.0
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 7ee95e5 into kcl-lang:main Sep 5, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants