Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting exisiting grammar and adding test cases #20

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

Vishalk91-4
Copy link
Contributor

@Vishalk91-4 Vishalk91-4 commented Jun 1, 2024

…ected attributes

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
re #2

2. What is the scope of this PR (e.g. component or file name):

  • grammar.js
  • grammar.json
  • node-types.json
  • test/corpus
  • parser.c

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

This PR completes the below tasks

  • Decorator Test Cases
  • Unification test cases
  • Attribute correction
  • Grammar and test case for Raw String
  • Adding More grammar for config and Test cases for Config_expr
  • Adding Test cases for Quant any and all

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Vishalk91-4
Copy link
Contributor Author

@Peefy
I'm working on this PR
The checklist of the tasks, I am going to complete is mentioned above
I'll finish the checklist, then open this PR up, if it's fine with you

@Vishalk91-4 Vishalk91-4 force-pushed the tree-defn branch 3 times, most recently from 812ae36 to 3dc4c64 Compare June 6, 2024 20:11
@Vishalk91-4 Vishalk91-4 marked this pull request as ready for review June 8, 2024 10:59
@Vishalk91-4
Copy link
Contributor Author

Vishalk91-4 commented Jun 8, 2024

@Peefy, It's ready for review

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1c93300 into kcl-lang:main Jun 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants