Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Additional Schema, Mixin and Rule opeations #25

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

Vishalk91-4
Copy link
Contributor

@Vishalk91-4 Vishalk91-4 commented Jul 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
re #2

2. What is the scope of this PR (e.g. component or file name):

gammar.js
schema.txt

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  • Improved Code for Schema Statements
  • Improved Code for Mixin Statements
  • Improved Code for Rule Statements
  • Added Test Cases for the above statements

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Vishalk91-4 Vishalk91-4 marked this pull request as ready for review August 11, 2024 10:57
@Vishalk91-4
Copy link
Contributor Author

@Peefy, could you review it

@Vishalk91-4 Vishalk91-4 changed the title [WIP] Added Additional Schemas and various config opeations Added Additional Schema, Mixin and Rule opeations Aug 16, 2024
@Peefy
Copy link
Contributor

Peefy commented Aug 16, 2024

Good Job! I will review it later.

@Peefy
Copy link
Contributor

Peefy commented Aug 17, 2024

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 610f2b5 into kcl-lang:main Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants