-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second sensor for historical data #58
Conversation
…eyev/eyeonwater into feature/add-historical-sensor
…ature/add-historical-sensor
This looks great, do you think I should reconstruct it a little differently and separate out the sensors in to different classes since this is only “temporary”? It would be much easier later on to remove all of the secondary sensor stuff that way. Otherwise, this will work the way it is. |
Yes, thank you! |
BTW, I never had those crazy problems with statistics, so the regular sensor works for me great |
No, i’ll work inside of your branch. I have not seen any abnormal values either! I’ll work on this on Sunday, tonight is a drinking evening 😁. |
Theres an import_historical_data in both the super(coordinater) and the sensor? Are they the same thing? |
Extra sensor created 👍🏼 |
@disforw Sorry, I missed your message. |
I see pre-commit checks are failing. let me fix it |
Should we merge it? |
I cleaned us up a little bit, looks good to me. Wanna just check it with a beta first? |
This PR addresses #30 and #43
The integration will add 2 different water meters:
The "statistic" one should be used in the Energy Dashboard as a workaround for the negative water usage values issue discussed in #30.