Some changes to fix the path problem under windows system and android TAK client #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbtxwer
commented
Aug 25, 2024
kbtxwer
commented
- improve the body limit so that it can be able to send large files
- directly write the file to it path instead of using a tempfile to avoid the rename operation on windows because it is easy going wrong
- modified the "getMetadataGetHandler" function to keep the same performance as the FreeTAKServer
- use "ctx.BaseURL() + packageUrl(pi)" instead of "packageUrl(pi)" because my tak client cannot determine which server to connect when the url is not given as full path, even when there is only one server connected. The FreeTAKServer also returns the full path url.
added 4 commits
August 26, 2024 00:51
2. directly write the file to it path instead of using a tempfile to avoid the rename operation on windows because it is easy going wrong 3. modified the "getMetadataGetHandler" function to keep the same performance as the FreeTAKServer 4. use "ctx.BaseURL() + packageUrl(pi)" instead of "packageUrl(pi)" because my tak client cannot determine which server to connect when the url is not given as full path, even when there is only one server connected. The FreeTAKServer also returns the full path url.
…ile path which will raise 404 error during access from web 2. EMBED webtak into the program 3. register webTakPathHandler to redirect /webtak to /webtak/ to avoid issues
…r single cast message to all feds
|
kdudkov
requested changes
Aug 27, 2024
|
|
||
| addMartiRoutes(app, api.f) | ||
| } else { | ||
| staticfiles.EmbedWebTak(api.f) |
There was a problem hiding this comment.
we don't want to use /webtak handle at all if it's not a webtacRoot
| } | ||
|
|
||
| func (c *PathUnescapeFs) Open(name string) (http.File, error) { | ||
| // 解码路径中的空格 |
There was a problem hiding this comment.
please use english comments only
| @@ -11,9 +12,33 @@ import ( | |||
| //go:embed static | |||
| var staticFiles embed.FS | |||
|
|
|||
| //go:embed webtak | |||
| var webtakFiles embed.FS | |||
There was a problem hiding this comment.
do not embed webtak in the binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.