Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Commit

Permalink
Merge pull request #528 from keep-network/sthompson22/keep-test/fix-c…
Browse files Browse the repository at this point in the history
…ircle-workflow

testing keep-test Circle workflow

There's a couple things we needed to address here.

1. When #485 was merged I failed
   to account for the job `setup_github_package_registry` being required in
   `migrate_contracts`.  When we merged the linked PR npm auth on contract
   migrations from the utility-box started failing as a result. This was observed
   in both `keep-dev` and `keep-test` migrations.  To address this we are now
   mounting the workspace that has `setup_github_package_registry` output to
   `migrate_contracts` and added a new job too remove the problematic
   `npm_modules` dir on scp to the utility-box.
2. Include git tag filters on the `compile_contracts` step.  This one is a bit
   perplexing but the job chain doesn't get produced unless the filter is present.
3. Updated the `keep-tecdsa` package to `0.10.0-rc`, and updated
   `package-lock.json` via `npm i`.
  • Loading branch information
Shadowfiend authored Mar 17, 2020
2 parents fbb2018 + 54e61fd commit b1506ea
Show file tree
Hide file tree
Showing 3 changed files with 3,121 additions and 1,762 deletions.
14 changes: 13 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,16 @@ jobs:
migrate_contracts:
executor: docker-thesis-buildpack
steps:
- checkout
- setup_remote_docker:
docker_layer_caching: true
- checkout
- attach_workspace:
at: .
- run:
name: Remove Installed node_module
working_directory: ~/project/implementation
command: |
rm -rf node_modules
- run:
name: Provision External Contract Addresses
command: |
Expand Down Expand Up @@ -301,6 +308,11 @@ workflows:
- compile_contracts:
requires:
- setup_github_package_registry
filters:
tags:
only: /^v.*/
branches:
ignore: /.*/
- migrate_contracts:
filters:
tags:
Expand Down
Loading

0 comments on commit b1506ea

Please sign in to comment.