Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Commit

Permalink
Refactoring : Removed Redundant logs in madara (#1563)
Browse files Browse the repository at this point in the history
  • Loading branch information
Arun Jangra authored Apr 15, 2024
1 parent 534eadf commit b1ba579
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next release

- refactoring : Removed Redundant logs in madara
- fix: transaction receipt fails for txs in the middle of a block
- chore: add makefile for developer experience improvements and cleanup
- fix: fix cargo-lint issues
Expand Down
1 change: 0 additions & 1 deletion crates/client/settlement/src/sync_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ where
messages_to_l1,
messages_to_l2,
};
log::info!("{:#?}", program_output);

settlement_provider.update_state(program_output).await?;

Expand Down
12 changes: 0 additions & 12 deletions crates/primitives/transactions/src/execution.rs
Original file line number Diff line number Diff line change
Expand Up @@ -376,17 +376,11 @@ pub trait Execute: Sized + GetAccountTransactionContext + GetTransactionCalldata
let mut execution_resources = ExecutionResources::default();
let mut remaining_gas = TX_INITIAL_AVAILABLE_GAS;

log::info!(">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>");

let account_tx_context = self.get_account_transaction_context(execution_config.offset_version);

log::info!("account txn context : {:?}", account_tx_context);

// Nonce and fee check should be done before running user code.
Self::handle_nonce_and_check_fee_balance(state, block_context, &account_tx_context, execution_config)?;

log::info!(">>>> nonce and check fee balance done ✅");

// execute
let ValidateExecuteCallInfo { validate_call_info, execute_call_info, revert_error } = self.execute_inner(
state,
Expand All @@ -397,8 +391,6 @@ pub trait Execute: Sized + GetAccountTransactionContext + GetTransactionCalldata
execution_config.disable_validation,
)?;

log::info!(">>>> execution call info validated ✅");

let (actual_fee, fee_transfer_call_info, actual_resources) = self.handle_fee(
state,
&execute_call_info,
Expand All @@ -409,8 +401,6 @@ pub trait Execute: Sized + GetAccountTransactionContext + GetTransactionCalldata
execution_config,
)?;

log::info!(">>>> fee handling done ✅");

let tx_execution_info = TransactionExecutionInfo {
validate_call_info,
execute_call_info,
Expand All @@ -420,8 +410,6 @@ pub trait Execute: Sized + GetAccountTransactionContext + GetTransactionCalldata
revert_error,
};

log::info!(">>>> txn execution info : {:?}", tx_execution_info);

Ok(tx_execution_info)
}

Expand Down

0 comments on commit b1ba579

Please sign in to comment.