Bug: fix failed l1 message tx replay #1513
Conversation
| storage::transactional::with_transaction(|| { | ||
| storage::TransactionOutcome::Commit(Result::<_, DispatchError>::Ok( | ||
| L1Messages::<T>::mutate(|nonces| nonces.insert(nonce)) | ||
| )) | ||
| })?; |
There was a problem hiding this comment.
@apoorvsadana Committing nonce data separately for error case, however it still doesn't commit to db. Can you please check once and help me out here.
|
PR on hold because the issue might potentially get fixed by a rebase on progress by @tdelabro |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
|
@prtk418 are you still working on this? |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
|
repository archived in favor of https://github.com/madara-alliance/madara |
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
Resolves: #1504