Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

added pallet test for InvokeTransaction::V0 #1608

Closed
wants to merge 20 commits into from
Closed

added pallet test for InvokeTransaction::V0 #1608

wants to merge 20 commits into from

Conversation

raizo07
Copy link

@raizo07 raizo07 commented May 18, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Testing
  • Feature

What is the current behavior?

All the transaction tests in are InvokeTransaction::V0

Resolves: missing V0 tests.

What is the new behavior?

  • We have a possibility to check V0 invokeTransactions.

Does this introduce a breaking change?

  • No

Other information

@raizo07
Copy link
Author

raizo07 commented May 18, 2024

@tdelabro I've opened a PR here, I think you should be able to review here. Thank you.

@EvolveArt
Copy link
Collaborator

thanks for this pr @raizo07, I think the issue was about declare v0 tho. Also in this PR you modify an existing test instead of adding a new one. Please also update changelog.

@raizo07
Copy link
Author

raizo07 commented May 21, 2024

thanks for this pr @raizo07, I think the issue was about declare v0 tho. Also in this PR you modify an existing test instead of adding a new one. Please also update changelog.

@EvolveArt Thank you for your comment. But from this link #1603 (comment) You can see that it is a different task I was asked to work on, of which I added the test. I'm open to further reviews.

crates/pallets/starknet/src/tests/invoke_tx.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests/invoke_tx.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests/invoke_tx.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests/invoke_tx.rs Outdated Show resolved Hide resolved
@tdelabro
Copy link
Collaborator

@raizo07, still working on it?

@raizo07
Copy link
Author

raizo07 commented May 30, 2024

@raizo07, still working on it?

Yes, I'll be sending the PR today.

@tdelabro
Copy link
Collaborator

tdelabro commented Jun 3, 2024

@raizo07 this time the tests don't even compile.
run cargo test on you computer

@raizo07 raizo07 closed this by deleting the head repository Jun 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants