log2 hint #454
Merged
log2 hint #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whichqua
reviewed
Jan 2, 2025
| from starkware.python.math_utils import log2_ceil | ||
| ids.res = log2_ceil(ids.value)"# | ||
| }; | ||
| pub fn log2_ceil_hint( |
There was a problem hiding this comment.
We possibly just need to remove the hint from unimplemented.rs
notlesh
reviewed
Jan 6, 2025
|
|
||
| #[allow(unused)] | ||
| pub const HINT_4: &str = indoc! {r#"exit_syscall(selector=ids.SHA256_PROCESS_BLOCK_SELECTOR)"#}; | ||
| // This file is intended to list all the unimplemented hints during an OS upgrade |
There was a problem hiding this comment.
Suggested change
| // This file is intended to list all the unimplemented hints during an OS upgrade | |
| // This file is intended to list all the unimplemented hints found by the `hint_tool` binary | |
| // when comparing the hints found in the compiled OS compared to the hints known by SNOS |
notlesh
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New hint from OS v0.13.3: log2 ceil. Implementation from the hint and a public function to compute the log2 since it will be needed in compression hints
KZG tests still require extra hints.
Check orphan hints is failing because it detects two extra hints that will be covered in compress PR (
COMPRESSandSET_DECOMPRESSED_DST)Issue Number: N/A
Type
Description
Breaking changes?