Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle the overview rendering properly #2579

Conversation

rajesh-jonnalagadda
Copy link
Contributor

@rajesh-jonnalagadda rajesh-jonnalagadda commented Nov 21, 2024

Closes #

📑 Description

handle the overview rendering properly.

replication steps:

  1. go to any workflow execution page.
  2. change the tabs filters in an overview.
  3. check the below loading. we can see the overview.

expected:
overview should not shown when it is in a loading state.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

@rajesh-jonnalagadda is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@dosubot dosubot bot added Bug Something isn't working UI User interface related issues labels Nov 21, 2024
@talboren
Copy link
Member

@rajesh-jonnalagadda can you add a ticket and a screenshot of what is this fixing? closing for now, please re-open once it's ready.

@talboren talboren closed this Nov 25, 2024
@rajesh-jonnalagadda
Copy link
Contributor Author

@talboren replicated the issue. above changes should fix the issue
https://www.loom.com/share/63d74b4ba9824f22bc296c61d29a0a06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants