Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feed counter #2587

Merged
merged 6 commits into from
Nov 24, 2024
Merged

fix: feed counter #2587

merged 6 commits into from
Nov 24, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Nov 24, 2024

Closes #2585

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 24, 2024
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 9:07am

keep/api/core/db.py Outdated Show resolved Hide resolved
Matvey-Kuk
Matvey-Kuk previously approved these changes Nov 24, 2024
keep/api/core/db.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (892a79e) to head (9bc29c2).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 57.14% 3 Missing ⚠️
keep/api/tasks/process_event_task.py 0.00% 3 Missing ⚠️
keep/api/routes/preset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
- Coverage   69.63%   69.48%   -0.15%     
==========================================
  Files         160      161       +1     
  Lines       15149    15196      +47     
==========================================
+ Hits        10549    10559      +10     
- Misses       4600     4637      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Kiryous Kiryous merged commit ea748d0 into main Nov 24, 2024
13 of 16 checks passed
@Kiryous Kiryous deleted the fix/2585-feed-counter branch November 24, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Feed counter is not updating
2 participants