Create worker subdirectory for worker docker image #15
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
======================================
Coverage 0.93% 0.93%
======================================
Files 3 3
Lines 215 215
======================================
Hits 2 2
Misses 213 213 ☔ View full report in Codecov by Sentry. |
|
@AnShafs, I believe that #3 calls for one additional change beyond what you've already made. The line which indicates "Move Dockerfile.worker and script for the worker image to this directory" is referring to Can you add that to the |
|
@davemasselink Thank you for pointing this out. I updated my branch. |
| docker build . -t ${IMG} | ||
| docker build . -t ${WORKERIMG} --file Dockerfile.worker | ||
| docker build -f ./controllers/Dockerfile . -t ${IMG} | ||
| docker build -f ./worker/Dockerfile.worker . -t ${WORKERIMG} |
There was a problem hiding this comment.
Let's rename this file to ./worker/Dockerfile since now we have it in its own subdirectory.
fixed #3