Kryoflux RAW : create any missing directories in output path

[renaudguerin]

Small quality of life improvement : when opening Kryoflux RAW files for writing, create any missing directories contained in the filename pattern.

I typically want to keep KF RAW files together in a subdirectory without having to create it manually beforehand (e.g. gw read greatgame/00.0.raw).

Note: I initially made the change at the Image class level but then realised that KF overloads the __enter__ method (and other formats might not benefit as much), so it's now in kryoflux.py only.

[keirf]

I don't know if I like this or not. Is it that hard to mkdir?

[renaudguerin]

I don't know if I like this or not. Is it that hard to mkdir?

Let's say it was enough of a recurring annoyance to make me decide to delve into the code and submit this :)

It always caught me when dealing with multiple disks or when re-reading a disk after cleaning it. I quickly edit the command line to change the destination, but forget to mkdir. Or I do have mkdir in the same command line, but now I need to edit the path in two places...

I understand the reluctance to introduce non explicit side effects in general, but arguably KF RAW is already special in the way it treats the input path as a pattern and creates multiple file destinations (in fact I didn't understand this the first time I used it and saw 160 files appear).

I can't think of any negative outcome if you also create missing directories in this pattern : when dumping full disks you'll almost always want directories to keep things tidy, and if you don't, well this patch doesn't affect you. Neither does it break anything if you already mkdir'd.

I suppose that if you made a typo, you could unintentionally end up silently creating directories instead of seeing an error, but in this corner case rmdir isn't that hard :)

[renaudguerin]

I've updated this patch for your latest changes, if you wanted to take another look.
Thanks.