fix for error on ie8 and older #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'substring': object is null" the object is the url.
|
|
||
| // IE8- bugfix | ||
| if (typeof(url) !== 'string') | ||
| return contextUrl; |
There was a problem hiding this comment.
s/b surrounded with curly braces
|
I had the same issue and this pull request fixed it for me (using version 1.0.3b + this mod). |
|
This worked for me. Thanks. |
|
@keithclark disappeared so I'm going to try and maintain this project at https://github.com/corysimmons/selectivizr2 Would you please reopen/rebase your PR over there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error on ie9comp, ie8 and older: "Unable to get value of the property 'substring': object is null"
the object is the url.