Developed Peters et al. 2022 lifter #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for the lifter_peters_et_al struct.
…ngements to parcel.h that Kelton may or may not be okay with.
… include issues in a much more elegant way than reshuffling <parcel.h> the way I did earlier
…ywhere across thermo.cpp.
…correct behavior.
…for parcel density temperature.
…o develop-peters-lifter I forgot that I deleted .vscode from the remote directory lol
…o develop-peters-lifter Remote repository had extraneous files deleted while local repository did not.
|
Thanks for making this PR @a-urq ! Sorry I didn't see this or get to it sooner. I'm on operational training shifts this summer, but I'll start taking a look at this on my non-ops shifts and start reviewing/testing the code and let you know if I have any further questions. I'm definitely interested in getting this merged into the main branch, as having the entraining parcel traces would be very useful and is something I haven't had the time to work on myself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Peters et al. lifter has been tested with all four types of moist ascent using a modified version of my sounding viewer as a Skew-T plotter, which has itself been tested against the ECAPE_FUNCTIONS python script written by John Peters. The SHARPlib-computed parcel is represented by a translucent green line.
I also found a few issues related to ECAPE computation in thermo.cpp's sharp::entrainment_cape and fixed them, most of which were related to differences between the preprint and the final published paper.
Pseudoadiabatic non-entraining:
Pseudoadiabatic entraining:
Irreversible adiabatic non-entraining:
Irreversible adiabatic entraining:
