Improving performance setting widget data. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options.dataIsSimpleJS is a simple property extending the binding options.
The reason for adding this property is to avoid unnecessary iteration/subscriptions through a possibly large dataset.
If we have a large dataset say > 35000 items the performance hit is quite big. Some browsers are not very forgiving (FF) and display non responsive script error.
If the consumer knows that his data are consisted by simple js objects , he can just set the new flag to true to avoid the iteration.
We could use the useKOTemplates to achieve the same , but it is not clear to me how that would affect now or in a future version consumer implementations.
Having an option decicated for this usage is the cleanest way to address this issue.
Here is a fiddle to demonstrate the performance difference using the useKOTemplates
http://jsfiddle.net/gtrifidis/mC4Vw/14/
Just remove the useKOTemplates from the binding to see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small performance improvement workaround when consumer knows upfront when widget data do not include any observables.