Fix odd rounding errors #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent this behavior: ```javascript (450 - 449.99999999999994) + 'px' "5.684341886080802e-14px" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you're not maintaining this, but thought I'd send this just in case someone else finds it useful. I was finding that the background was jumping around on me in Chrome. It turned out that for very long decimals, it was rendering the numbers as scientific numbers and then concatenating them to 'px' and treating 0.00000000000005 px the same as 5px. This rounds up to a whole pixel value.
Prevent this behavior: