[chore] Add several vis state mergers combineConfigs and improve TS #2634
+371
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Dykhta <[email protected]>
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks like there is a failed test |
heshan0131
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
combineConfigsto some vis state saved configs that are non-array complex objects:interactionConfiglayerBlendingoverlayBlendingeditorEach of these has inline comments (and unit tests) explaining the decisions made on how to combine values in different situations. For example,
interactionConfig.brush.sizegets aggregated into keeping the single largest value among all brush sizes.Improves and fixes some TS defs.
Adds jest unit tests for newly added
combineConfigs.