bpf, arm64: Simplify if logic in emit_lse_atomic() #4825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
a16555e to
5b81b0c
Compare
|
Upstream branch: 9468f39 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/921189=>bpf-next
branch
from
32e33be to
5108796
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5b81b0c to
70e482f
Compare
Delete that unnecessary outer if clause. No functional changes. Signed-off-by: Peilin Ye <[email protected]>
…omic()
Currently in emit_{lse,ll_sc}_atomic(), if there is an offset, we add it
to the base address by emitting two instructions, for example:
if (off) {
emit_a64_mov_i(1, tmp, off, ctx);
emit(A64_ADD(1, tmp, tmp, dst), ctx);
...
As pointed out by Xu, we can combine the above into a single A64_ADD_I
instruction if 'is_addsub_imm(off)' is true, or an A64_SUB_I, if
'is_addsub_imm(-off)' is true.
Suggested-by: Xu Kuohai <[email protected]>
Signed-off-by: Peilin Ye <[email protected]>
|
Upstream branch: 654a338 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/921189=>bpf-next
branch
from
5108796 to
597d6d9
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=921189 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf, arm64: Simplify if logic in emit_lse_atomic()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=921189