Various fixes 12 2024 #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent pods from being evicted first. Signed-off-by: Denys Fedoryshchenko <[email protected]>
Fixes crash:
```
12/23/2024 05:28:21 PM UTC [ERROR] Traceback (most recent call last):
File "/home/kernelci/pipeline/src/base.py", line 69, in run
status = self._run(context)
^^^^^^^^^^^^^^^^^^
File "/home/kernelci/pipeline/./src/scheduler.py", line 296, in _run
self._run_job(job, runtime, platform, input_node)
File "/home/kernelci/pipeline/./src/scheduler.py", line 80, in _run_job
node = self._api_helper.create_job_node(job_config, input_node,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/api/helper.py", line 402, in create_job_node
'kernel_revision': input_node['data']['kernel_revision'],
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'kernel_revision'
```
Signed-off-by: Denys Fedoryshchenko <[email protected]>
Fix crash on faulty tree, for example: ``` fatal: unable to access 'https://gitlab.collabora.com/google/chromeos-kernel.git/': The requested URL returned error: 502 12/22/2024 12:13:51 PM UTC [ERROR] Traceback (most recent call last): File "/home/kernelci/pipeline/src/base.py", line 69, in run status = self._run(context) ^^^^^^^^^^^^^^^^^^ File "/home/kernelci/pipeline/./src/trigger.py", line 145, in _run self._iterate_build_configs(force, build_configs_list, File "/home/kernelci/pipeline/./src/trigger.py", line 120, in _iterate_build_configs self._run_trigger(config, force, timeout, trees) File "/home/kernelci/pipeline/./src/trigger.py", line 46, in _run_trigger head_commit = kernelci.build.get_branch_head(build_config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/kernelci/build.py", line 81, in get_branch_head head = shell_cmd(cmd) ^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/kernelci/__init__.py", line 29, in shell_cmd return subprocess.check_output(cmd, shell=True).decode() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/subprocess.py", line 466, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command 'git ls-remote https://gitlab.collabora.com/google/chromeos-kernel.git refs/heads/for-kernelci' returned non-zero exit status 128. ``` Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
various-fixes-12-2024
branch
from
639a752 to
7dd41b3
Compare
|
Tested on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)pod memory allocation
2)scheduler fix due missing keys in node
3)trigger fix due tree returning tree during head retrieval