config: pipeline: Update CONFIG_FRAME_WARN for i386 #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
musamaanjum
commented
Dec 31, 2024
•
musamaanjum
commented
For reference: #870 |
pawiecz
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
LGTM
minor: copying commit message body from #870 here (including reference to the kernelci/kernelci-project#482 - as is, i.e. with Close: tag) could be useful for tracking change history
musamaanjum
force-pushed
the
stack_frame
branch
from
e51c48a to
b9c5549
Compare
CONFIG_FRAME_WARN is set to 1024 by default for i386. The allowed value for this is 0 to 8192. Let's increase it to 2048 to avoid getting the warning when stack size is more than default 1024. As all warnings are being treated as errors, our allmodconfig build fails. Example of a build failure: https://kcidb.kernelci.org/d/build/build?var-datasource=edquppk2ghfcwc&var-origin=maestro&var-build_architecture=$__all&var-build_config_name=$__all&var-id=maestro:6772ceda423acf18d263ca6b&var-test-path=boot&from=now-100y&to=now&timezone=browser&var-test_path=&var-issue_presence=yes Related kernelci#870 Close kernelci/kernelci-project#482 Signed-off-by: Muhammad Usama Anjum <[email protected]>
musamaanjum
force-pushed
the
stack_frame
branch
from
b9c5549 to
494b396
Compare
|
Updated the commit message. |
|
I created Node 6773ec42ddafeb87332c75bc to verify this PR using: I'll merge this PR when the build is successfully completed |
|
Processing the Node completed successfully, config includes requested changes |
|
@nuclearcat I've got the failure again on 6th Jan. I assume the production hasn't been updated yet. |
|
It got updated just today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.