Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Routing Preference Tests #824

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Add Routing Preference Tests #824

merged 6 commits into from
Nov 27, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Nov 13, 2024 •
edited
Loading

This PR introduces two new test cases to the ietf-routing test suite:

  • DHCP vs Static Route Preference
  • OSPF vs Static Route Preference
  • Static Route Inactivation with Preference 255

Additionally, this PR includes minor improvements in Infamy:

  • Enhanced route verification
  • Updates to the IsolatedMacVlan class
  • Enhancements to the DHCP Server class

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar self-assigned this Nov 13, 2024
mattiaswal
mattiaswal requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mattiaswal mattiaswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just small things. Very small 🥇

test/case/ietf_routing/route_pref_255/topology.png Outdated Show resolved Hide resolved
test/case/ietf_routing/route_pref_dhcp/test.py Outdated Show resolved Hide resolved
test/case/ietf_routing/route_pref_dhcp/test.py Outdated Show resolved Hide resolved
@axkar axkar force-pushed the add-routing-pref-tests branch 2 times, most recently from 8369b40 to 1d119da Compare November 25, 2024 07:56
@axkar axkar force-pushed the add-routing-pref-tests branch 2 times, most recently from d8173ed to 2452ea5 Compare November 26, 2024 12:53
@axkar
Copy link
Collaborator Author

axkar commented Nov 27, 2024

ping for re-review @mattiaswal 😄

@axkar axkar merged commit eabf79c into main Nov 27, 2024
5 checks passed
@axkar axkar deleted the add-routing-pref-tests branch November 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiaswal mattiaswal mattiaswal approved these changes

Assignees

@axkar axkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axkar @mattiaswal