fix: don't show colons on android (#23786)

* fix: don't show colons on android * fix: add comment with issue
keybase · Apr 15, 2020 · e81aee5 · e81aee5
1 parent c47a50e
commit e81aee5
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/shared/teams/emojis/common.tsx b/shared/teams/emojis/common.tsx
@@ -42,7 +42,9 @@ export class AliasInput extends React.PureComponent<AliasInputProps, {}> {
             error={!!this.props.error}
             disabled={this.props.disabled}
             textType={Styles.isMobile ? 'BodySemibold' : 'Body'}
-            value={`:${this.props.alias}:`}
+            // android has issues with setSelection that make including colons a bad experience
+            // see https://keybase.atlassian.net/browse/TRIAGE-2680
+            value={Styles.isAndroid ? this.props.alias : `:${this.props.alias}:`}
             containerStyle={Styles.collapseStyles([
               styles.aliasInput,
               !this.props.small && styles.aliasInputLarge,
@@ -52,7 +54,8 @@ export class AliasInput extends React.PureComponent<AliasInputProps, {}> {
               this.props.onChangeAlias(newText.replace(/[^a-zA-Z0-9-_+]/g, ''))
             }
             onEnterKeyDown={this.props.onEnterKeyDown}
-            onFocus={this.onFocus}
+            // TODO: remove android exception when https://keybase.atlassian.net/browse/TRIAGE-2680 fixed
+            onFocus={Styles.isAndroid ? undefined : this.onFocus}
           />
           {this.props.onRemove && (
             <Kb.ClickableBox onClick={this.props.onRemove} style={styles.removeBox}>