-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EEPROM and focus support to ColormapOverlay #1434
base: master
Are you sure you want to change the base?
Add EEPROM and focus support to ColormapOverlay #1434
Conversation
@@ -73,6 +74,10 @@ EventHandlerResult ColormapOverlay::beforeSyncingLeds() { | |||
return EventHandlerResult::OK; | |||
} | |||
|
|||
EventHandlerResult ColormapOverlay::onFocusEvent(const char *input) { | |||
return ::LEDPaletteTheme.themeFocusEvent(input, PSTR("colormap.overlay"), map_base_, no_themes_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colormap.overlay
seems like the most logical focus command to me. Let me know what you think.
@EvyBongers did you end up testing this on hardware? |
I completely forgot about this. I'll see about testing it today |
So, I finally got around to testing this. The command returns the palette indexes as expected, but setting the indexes doesn't yet work 🤔 |
So, I dug a little deeper to see what I was missing. I thought I had a quick fix by calling on The confusing part is that Colormap-Overlay (seemed to) need to call Closing this for now |
Reopened because EEPROM supports needs to be added anyway and EEPROM and focus support should land together. |
Just found a comment about this on Discord. Cross-posting to have all of this together.
|
Signed-off-by: Evy Bongers <[email protected]>
41ea3cb
to
912fc39
Compare
Quick attempt to implement focus support in ColormapOverlay. I feel this should work, but I don't have my keyboard with me right now, so any debugging I'll have to do later.