refactor: split common parts out of build.sh #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
reviewed
Sep 26, 2023
Comment on lines
+96
to
+104
| if [ ! -L vendor ]; then | ||
| # Create link to vendor/ folder | ||
| CONTAINER_ID=$(get_docker_container_id $CONTAINER_NAME) | ||
| if [ -z "$CONTAINER_ID" ]; then | ||
| builder_die "Docker container appears to have failed to start in order to create link to vendor/" | ||
| fi | ||
|
|
||
| docker exec -i $CONTAINER_ID sh -c "ln -s /var/www/vendor vendor && chown -R www-data:www-data vendor" | ||
| fi |
There was a problem hiding this comment.
Will docker.inc.sh eventually get refactored to a separate/shared repo?
We would skip this for sites that don't use composer, right?
There was a problem hiding this comment.
Will docker.inc.sh eventually get refactored to a separate/shared repo?
Yes, that's my thinking. We may have a code snippet to source it via curl, and then it will copy other shared elements in with build.sh configure
We would skip this for sites that don't use composer, right?
Yes we may need to add a bit to skip the vendor copy for s.keyman.com etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.