chore: Add docs for Android HTML banner #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
LGTM. But I wonder if we should make it clearer when you would use one or the other. First I thought I'd use setHTMLBanner if I have only inline content and copyHTMLBannerAssets if there are files involved, but then I noticed the keyboardType parameter and wondered how you do that with copyHTMLBannerAssets.
developer/engine/android/17.0/KMManager/copyHTMLBannerAssets.md
Outdated
Show resolved
Hide resolved
developer/engine/android/17.0/KMManager/copyHTMLBannerAssets.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Eberhard Beilharz <[email protected]>
Co-authored-by: Eberhard Beilharz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the KMManager API calls added for controlling the Android HTML banner in keymanapp/keyman#9696