feat(developer): range warning for non-NFD chars 🙀 #10614
Conversation
srl295
requested review from
mcdurdin,
darcywong00 and
jahorton
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
…oper/10316-range-warning
| protected analyzeCodePoint(c: string, ch: number): BadStringType { | ||
| const nfd = c.normalize("NFD"); | ||
| if (c !== nfd) { | ||
| return BadStringType.denormalized; | ||
| } else { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
I wonder about the performance of this -- seems like it could be quite expensive?
There was a problem hiding this comment.
right. maybe some kind of cache would help.
There was a problem hiding this comment.
it's only on actual ranges in transforms.
There was a problem hiding this comment.
OK, limited use so we can probably ignore for now. If it's always a single codepoint we could build a map and ship it -- trivial. Danger with that is that if we use normalize() elsewhere then the map could be inconsistent wrt Unicode version.
|
Our messages (errors, hints, and warnings) don't have line numbers at present, which is going to be quite painful for users! |
|
…oper/10316-range-warning
|
Changes in this pull request will be available for download in Keyman version 17.0.262-alpha |
Fixes: #10316
@keymanapp-test-bot skip