Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): finalization for replacement of Karma with Web Test Runner 🏃 #11300

Merged
merged 1 commit into from
May 23, 2024

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Apr 25, 2024

Fixes #10497.

Now that we've finished converting our browser-based testing engine from Karma to @web/test-runner, we can formally remove our old test-engine's dependencies entirely - an action with a notably large changeset of its own.

@keymanapp-test-bot skip

@jahorton jahorton added this to the A18S1 milestone Apr 25, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Apr 25, 2024
@jahorton jahorton force-pushed the chore/web/web-test-runner-trials branch from 0bd13ee to 1207c37 Compare May 15, 2024 08:44
@jahorton jahorton changed the base branch from chore/web/lm-worker-test-migration to chore/web/e2e-test-migration May 15, 2024 08:44
@jahorton jahorton changed the title chore(web): working branch - replacement of Karma with Web Test Runner 🏃 chore(web): finalization for replacement of Karma with Web Test Runner 🏃 May 15, 2024
@jahorton jahorton marked this pull request as ready for review May 15, 2024 08:49
@jahorton jahorton requested a review from ermshiperete as a code owner May 15, 2024 08:49
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't review every line of code in all the tests, but the PR chains looks good to me.

Base automatically changed from chore/web/e2e-test-migration to master May 23, 2024 00:41
@jahorton jahorton merged commit 7c34887 into master May 23, 2024
15 checks passed
@jahorton jahorton deleted the chore/web/web-test-runner-trials branch May 23, 2024 00:42
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.42-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(web): karma is deprecated, find an alternative test runner
5 participants