-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): finalization for replacement of Karma with Web Test Runner 🏃 #11300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Apr 25, 2024
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
common/
common/web/
chore
web/
developer/
common/models/
developer/compilers/
common/resources/
Build infrastructure
common/models/templates/
common/models/wordbreakers/
and removed
web/
labels
Apr 25, 2024
jahorton
changed the title
chore(web): working branch - replacement of Karma with Web Test Runner
chore(web): working branch - replacement of Karma with Web Test Runner 🏃
Apr 29, 2024
jahorton
force-pushed
the
chore/web/web-test-runner-trials
branch
from
April 29, 2024 09:14
9e445db
to
d000103
Compare
github-actions
bot
added
common/models/
common/models/templates/
common/models/wordbreakers/
and removed
web/
developer/
common/models/
developer/compilers/
common/resources/
Build infrastructure
common/models/templates/
common/models/wordbreakers/
labels
Apr 29, 2024
github-actions
bot
added
common/resources/
Build infrastructure
developer/
developer/compilers/
labels
May 10, 2024
jahorton
force-pushed
the
chore/web/web-test-runner-trials
branch
from
May 15, 2024 08:44
0bd13ee
to
1207c37
Compare
github-actions
bot
added
common/models/
common/models/templates/
common/models/wordbreakers/
common/resources/
Build infrastructure
developer/
developer/compilers/
and removed
developer/
common/models/
developer/compilers/
common/resources/
Build infrastructure
common/models/templates/
common/models/wordbreakers/
labels
May 15, 2024
jahorton
changed the base branch from
chore/web/lm-worker-test-migration
to
chore/web/e2e-test-migration
May 15, 2024 08:44
jahorton
changed the title
chore(web): working branch - replacement of Karma with Web Test Runner 🏃
chore(web): finalization for replacement of Karma with Web Test Runner 🏃
May 15, 2024
mcdurdin
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn't review every line of code in all the tests, but the PR chains looks good to me.
ermshiperete
approved these changes
May 22, 2024
Changes in this pull request will be available for download in Keyman version 18.0.42-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10497.
Now that we've finished converting our browser-based testing engine from Karma to @web/test-runner, we can formally remove our old test-engine's dependencies entirely - an action with a notably large changeset of its own.
@keymanapp-test-bot skip