Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): cleanup displayUnderlying flag in kmw compiler 🗜 #9056

Merged

Conversation

mcdurdin
Copy link
Member

Relates to #8955.

@keymanapp-test-bot skip

@mcdurdin mcdurdin added this to the A17S15 milestone Jun 21, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jun 21, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

let kvk: VisualKeyboard.VisualKeyboard = reader.read(kvkData);
let result = VisualKeyboardFromFile(kvk, options.saveDebug);
if(!result.result) {
// TODO: error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not possible - VisualKeyboardFromFile always returns a string.

@mcdurdin mcdurdin marked this pull request as ready for review June 21, 2023 04:48
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner June 21, 2023 04:48
Base automatically changed from chore/developer/cleanup-font-style-in-kvk to feature-kmc-kmw June 23, 2023 03:24
@mcdurdin mcdurdin merged commit 2222e87 into feature-kmc-kmw Jun 23, 2023
@mcdurdin mcdurdin deleted the chore/developer/cleanup-display-underlying-flag branch June 23, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants