chore(developer): handle layout file errors in kmw-compiler #9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes leftover commented code, and changes an enum to string enum type in order to get constant names for free for an error message. Error_TouchLayoutIdentifierRequires15 was split into its own error message because it was overloaded with CERR_TouchLayoutInvalidIdentifier previously but had a different message.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
59 tasks
jahorton
approved these changes
Jun 26, 2023
mcdurdin
added a commit
that referenced
this pull request
Jun 26, 2023
The tests for layout validity in #9087 were incomplete; first, they didn't fail the build if a key had invalid identifier, and second, there were some constants missing from the KeyIdType test (imperfect translation from the Delphi code in this case).
Base automatically changed from
chore/developer/kmc-kmw-cleanup-javascript-strings
to
feature-kmc-kmw
June 26, 2023 07:28
mcdurdin
deleted the
chore/developer/kmc-kmn-kmwcompiler-handle-layout-file-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #8955.
Also removes leftover commented code, and changes an enum to string enum type in order to get constant names for free for an error message.
Error_TouchLayoutIdentifierRequires15was split into its own error message because it was overloaded withCERR_TouchLayoutInvalidIdentifierpreviously but had a different message.@keymanapp-test-bot skip