Skip to content

Commit

Permalink
[minhateca] Fix duration parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
phihag committed Dec 4, 2014
1 parent ab07963 commit e8df5ce
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 6 deletions.
3 changes: 3 additions & 0 deletions test/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ def test_parse_duration(self):
self.assertEqual(parse_duration('0s'), 0)
self.assertEqual(parse_duration('01:02:03.05'), 3723.05)
self.assertEqual(parse_duration('T30M38S'), 1838)
self.assertEqual(parse_duration('5 s'), 5)
self.assertEqual(parse_duration('3 min'), 180)
self.assertEqual(parse_duration('2.5 hours'), 9000)

def test_fix_xml_ampersands(self):
self.assertEqual(
Expand Down
5 changes: 3 additions & 2 deletions youtube_dl/extractor/minhateca.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
)
from ..utils import (
int_or_none,
parse_duration,
parse_filesize,
)

Expand Down Expand Up @@ -52,8 +53,8 @@ def _real_extract(self, url):
filesize_approx = parse_filesize(self._html_search_regex(
r'<p class="fileSize">(.*?)</p>',
webpage, 'file size approximation', fatal=False))
duration = int_or_none(self._html_search_regex(
r'(?s)<p class="fileLeng[ht][th]">.*?([0-9]+)\s*s',
duration = parse_duration(self._html_search_regex(
r'(?s)<p class="fileLeng[ht][th]">.*?class="bold">(.*?)<',
webpage, 'duration', fatal=False))
view_count = int_or_none(self._html_search_regex(
r'<p class="downloadsCounter">([0-9]+)</p>',
Expand Down
19 changes: 15 additions & 4 deletions youtube_dl/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1206,18 +1206,29 @@ def parse_duration(s):

m = re.match(
r'''(?ix)T?
(?:
(?P<only_mins>[0-9.]+)\s*(?:mins?|minutes?)\s*|
(?P<only_hours>[0-9.]+)\s*(?:hours?)|
(?:
(?:(?P<hours>[0-9]+)\s*(?:[:h]|hours?)\s*)?
(?P<mins>[0-9]+)\s*(?:[:m]|mins?|minutes?)\s*
)?
(?P<secs>[0-9]+)(?P<ms>\.[0-9]+)?\s*(?:s|secs?|seconds?)?$''', s)
(?P<secs>[0-9]+)(?P<ms>\.[0-9]+)?\s*(?:s|secs?|seconds?)?
)$''', s)
if not m:
return None
res = int(m.group('secs'))
res = 0
if m.group('only_mins'):
return float_or_none(m.group('only_mins'), invscale=60)
if m.group('only_hours'):
return float_or_none(m.group('only_hours'), invscale=60 * 60)
if m.group('secs'):
res += int(m.group('secs'))
if m.group('mins'):
res += int(m.group('mins')) * 60
if m.group('hours'):
res += int(m.group('hours')) * 60 * 60
if m.group('hours'):
res += int(m.group('hours')) * 60 * 60
if m.group('ms'):
res += float(m.group('ms'))
return res
Expand Down

0 comments on commit e8df5ce

Please sign in to comment.