-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging Gov portal submissions #265
base: dev
Are you sure you want to change the base?
Conversation
You were going to add modals or something too right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible try paginating it (as in displaying only the first 10 results or so, and then the rest in a next/prev set)
Save the data in the template itself as JS and change up stuff I guess
@Goose-Of-War this is the popup modal u were referring to right, to clarify, on click it would sort of magnify to the page and show the artwork and stuff. ig i can do implement that.
sureee but like one of the points of paginating it is so u only send enough info to the client right. i mean i can implement the pagination part in client side itself i don't mind but should I directly do it in the server side. also the artwork and amv page could use pagination so i thought if anyone is implementing it, it would be done on a whole |
but in the artworks page its probably better to implement pagination sort of dynamically. when the user scrolls to a certain point, it is fetched |
We currently don't have an API model or something for fetched. So if you want to do that, it'll be more like you are just storing the addresses. Also, the three column CSS also has some special requirements; you can't fit any sets of images, unless you want the page to resize often |
It's more of a "if we need it only" kinda thing. You don't necessarily need it if the current UI (which is shit, hopefully the migrated one is better) is what you are going to use. |
I think it would be better to implement it in the newer UI tbh. |
I can do the pagination bit for the current site though |
hello guys. i finished the gov portal submissions stuff. here is a draft PR for reviews.
progress: