Fix session bug #261
Merged
Fix session bug #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't actuully using zip lists in the target rule (likely since filtering by session was added) - this expands twice to ensure zip lists are used, filtering the session with the filter_list() function. Note: should revamp sometime soon to use new snakebids API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when bids datasets have multiple sessions and not all subjects have the same session.
Using zip_lists solves that, but it turns out zip lists were not actually being used in the target rule, since the last refactoring of the target rules #63
This ensures zip_lists are used and filters with this expands twice in the
get_final_output()function to ensure zip listsare used, filtering the session with the filter_list() function.
Note: should revamp sometime soon to use new snakebids API..