Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docpatch #284

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Docpatch #284

merged 3 commits into from
Mar 5, 2024

Conversation

jordandekraker
Copy link
Collaborator

No description provided.

Jordan DeKraker - B. Bernhardt Lab and others added 3 commits March 5, 2024 13:42
RTD was still using py3.7, which on its own probably would have been
okay. However, pybids/bids-validator now has a minimum python
requirement of py3.8, which I suspect made some changes to
`functools.lru_cache`. These changes caused RTD to error out when trying
to read the `bids-validator` code.
@kaitj
Copy link
Contributor

kaitj commented Mar 5, 2024

(From message in commit 565n669)

RTD was still using py3.7 (EOL), which on its own probably would have been okay. However, pybids/bids-validator now has a minimum python requirement of py3.8, which I suspect made some changes to functools.lru_cache. These changes caused RTD to error out when trying to read the bids-validator code since it uses that caching function.

@jordandekraker jordandekraker merged commit 8ad3b21 into master Mar 5, 2024
5 checks passed
@jordandekraker jordandekraker deleted the docpatch branch March 5, 2024 23:12
akhanf pushed a commit that referenced this pull request Apr 25, 2024
* lock requirements versions

* format

* Force RTD to use py3.8

RTD was still using py3.7, which on its own probably would have been
okay. However, pybids/bids-validator now has a minimum python
requirement of py3.8, which I suspect made some changes to
`functools.lru_cache`. These changes caused RTD to error out when trying
to read the `bids-validator` code.

---------

Co-authored-by: Jordan DeKraker - B. Bernhardt Lab <[email protected]>
Co-authored-by: Jason Kai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants