[JBPM-10188] Signaling process instances

Original expression needs to be added as it is to external event listeners. This way it can be converted when persisted.
kiegroup · Aug 17, 2023 · 1ec71d0 · 1ec71d0
1 parent 829c59f
commit 1ec71d0
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/jbpm-flow/src/main/java/org/jbpm/workflow/instance/impl/WorkflowProcessInstanceImpl.java b/jbpm-flow/src/main/java/org/jbpm/workflow/instance/impl/WorkflowProcessInstanceImpl.java
@@ -622,10 +622,9 @@ protected void registerExternalEventNodeListeners() {
         for (Node node : getWorkflowProcess().getNodes()) {
             if (node instanceof EventNode && "external".equals(((EventNode) node).getScope())) {
                 String eventType = ((EventNode) node).getType();
+                addEventListener(eventType, EMPTY_EVENT_LISTENER, true);
                 if (isVariableExpression(eventType)) {
                     addEventListener(resolveVariable(eventType), EMPTY_EVENT_LISTENER, true);
-                } else {
-                    addEventListener(eventType, EMPTY_EVENT_LISTENER, true);
                 }
             } else if (node instanceof EventSubProcessNode) {
                 List<String> events = ((EventSubProcessNode) node).getEvents();
@@ -648,10 +647,9 @@ private void unregisterExternalEventNodeListeners() {
         for (Node node : getWorkflowProcess().getNodes()) {
             if (node instanceof EventNode && "external".equals(((EventNode) node).getScope())) {
                 String eventType = ((EventNode) node).getType();
+                removeEventListener(eventType, EMPTY_EVENT_LISTENER, true);
                 if (isVariableExpression(eventType)) {
                     removeEventListener(resolveVariable(eventType), EMPTY_EVENT_LISTENER, true);
-                } else {
-                    removeEventListener(eventType, EMPTY_EVENT_LISTENER, true);
                 }
             }
         }
@@ -909,7 +907,6 @@ private Optional<Object> resolveExpressionVariable(String paramName, VariableRes
             if(factory.isResolveable(paramName)) {
                 return Optional.of(factory.getVariableResolver(paramName).getValue());
             }
-
             return Optional.ofNullable(MVELSafeHelper.getEvaluator().eval(paramName, factory));
         } catch (Throwable t) {
             logger.error("Could not find variable scope for variable {}", paramName);