RHPAM-4822 find EventNode by unique id #2347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
added 3 commits
October 17, 2023 10:27
|
SonarCloud Quality Gate failed.
|
elguardian
reviewed
Oct 19, 2023
| <dependency> | ||
| <groupId>org.jbpm</groupId> | ||
| <artifactId>jbpm-services-api</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
this is not correct at all. the engine cannot depend on the services api at all.
elguardian
reviewed
Oct 19, 2023
| private Node getNodeByNodeInstanceId(long id, long nodeInstanceId) { | ||
| Node node = null; | ||
| RuntimeDataService service = (RuntimeDataService) ServiceRegistry.get().service(ServiceRegistry.RUNTIME_DATA_SERVICE); | ||
| Collection<NodeInstanceDesc> nodes = service.getProcessInstanceNodeInstanceHistory(id, nodeInstanceId, new QueryContext(0, 1)); |
There was a problem hiding this comment.
incorrect either. the engine should not access the runtime data service. this goes against the design.
elguardian
requested changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RHPAM-4822
Avoid classcastexception finding event nodes by unique id