Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10233] Using original list of nodes for dispatching #2424

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 10, 2024

If a catch with same event type was created as part of trigger complete, the new catch was signalled.

JIRA:

link

@fjtirado fjtirado requested a review from gmunozfe June 10, 2024 12:19
@fjtirado
Copy link
Contributor Author

jenkins run fdb

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, awesome fix @fjtirado !

@gmunozfe gmunozfe added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jun 10, 2024
@gmunozfe
Copy link
Member

Failing test seems unrelated:

org.kie.server.integrationtests.jbpm.JobServiceIntegrationTest.testScheduleAndRequeueJob[JAXB KieServicesConfiguration{transport=REST, serverUrl='http://localhost:38311/kie-server-services/services/rest/server'}]

Synchronization failed for defined timeout: 240000 milliseconds.
java.util.concurrent.TimeoutException: Synchronization failed for defined timeout: 240000 milliseconds.
at org.kie.server.integrationtests.jbpm.JobServiceIntegrationTest.scheduleAndRequeueJob(JobServiceIntegrationTest.java:311)
at org.kie.server.integrationtests.jbpm.JobServiceIntegrationTest.testScheduleAndRequeueJob(JobServiceIntegrationTest.java:259)
Standard Output
09:52:26.699 [main] INFO o.d.c.k.b.i.InternalKieModuleProvider - Creating KieModule for artifact org.kie.server.testing:query-definition-project:1.0.0.Final
09:52:26.700 [main] INFO o.d.m.CanonicalKieModuleProvider - No executable model found for artifact org.kie.server.testing:query-definition-project:1.0.0.Final. Falling back to resources parsing.

@fjtirado fjtirado merged commit 2ed7d56 into kiegroup:main Jun 11, 2024
5 of 9 checks passed
fjtirado added a commit that referenced this pull request Jun 18, 2024
fjtirado added a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants