fix(devnet): ignore duplicate epoch reports #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to a fix on devnet , a previous report event was replayed with same epoch
0xpanoramix
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (PR) introduces a fix for duplicate epoch reports that occur due to events being replayed on the development network (devnet). The changes ensure that if a report with the same epoch is encountered, it will not be processed again, effectively preventing redundancies.
Summary
Code Changes
Enhanced Event Handling: The core modification is in the event handling function
handleProcessedReport. A conditional check has been added to ascertain if the report associated with a specific epoch already exists in the database. If it does, the function returns early, bypassing unnecessary processing of duplicate events .Report Creation Logic: In the event that the report does not exist, a new report is created. The updated logic ensures that only unique epoch reports are considered for storage, which optimizes the handling of report data .