-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to support main new and edited events #49
base: master
Are you sure you want to change the base?
feat: update to support main new and edited events #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on balance tracking
deposit.mintedShares = event.params.mintedTokens; | ||
deposit.hash = event.transaction.hash; | ||
deposit.staker = event.params.staker; | ||
deposit.recipient = event.params.recipient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L.560 should also should edit the recipient balance instead of the staker i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set the staker
var to event.params.recipient
so it only touches the recipient balance. staker
is only stored in the ERC20Deposit
No description provided.