Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to support main new and edited events #49

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mortimr
Copy link
Contributor

@mortimr mortimr commented Oct 2, 2024

No description provided.

@mortimr mortimr requested review from gauthiermyr and 0xvv October 3, 2024 08:42
Copy link
Contributor

@0xvv 0xvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on balance tracking

deposit.mintedShares = event.params.mintedTokens;
deposit.hash = event.transaction.hash;
deposit.staker = event.params.staker;
deposit.recipient = event.params.recipient;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L.560 should also should edit the recipient balance instead of the staker i think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the staker var to event.params.recipient so it only touches the recipient balance. staker is only stored in the ERC20Deposit

@mortimr mortimr marked this pull request as draft October 3, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants