Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make src/docs/copy.sh a little more robust #1107

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

erooke
Copy link
Contributor

@erooke erooke commented Nov 14, 2024

/bin/bash is not guaranteed to exist on all systems. Replacing the shebang with #!/usr/bin/env bash increases portability for these systems.

Quoting arguments in bash prevents weird problems with word splitting and globbing.

`/bin/bash` is not guaranteed to exist on all systems. Replacing the
shebang with `/usr/bin/env bash` looks up the location of bash on such
systems.
@daniel-larraz daniel-larraz merged commit cc2ebc2 into kind2-mc:develop Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants