Make test runner script a little more resiliant #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`...` is legacy syntax, $(...) is preferred: http://mywiki.wooledge.org/BashFAQ/082 https://www.shellcheck.net/wiki/SC2006
In bash functions must be defined before they are called. `print_error` was defined after its call site resulting in an error when called
In bash `$@` is an array. Doing `x=$@` is assigning an array to a string. Different shells handle this differently. `$*` is explicit about wanting to concatenate the array to a list which is the behavior we are currently relying on. https://www.shellcheck.net/wiki/SC2124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/env bashinstead of/bin/bashas/bin/bashis not guaranteed to exist$(...)not`...`for command substitution.`...`is old and has lots of undefined behavior.print_errorwas defined after its call site resulting in an error when called.
$@is ambiguous,$*explicitly produces the behavior we are relying on.