Fix first tab condition

news/26.bugfix

@@ -0,0 +1 @@
+Fix first tab condition @reebalazs

src/kitconcept/solr/services/solr.py

@@ -105,6 +105,9 @@ def reply(self):
                 raise BadRequest(
                     "Property 'group_select` must be an integer, if specified"
                 )
+        elif len(solr_config.filters) > 0:
+            # By default select group 0 (unless there are no filters defined)
+            group_select = 0
 
         facet_fields = (
             solr_config.select_facet_fields(group_select)

tests/services/custom_config/test_endpoint_first_tab.py

@@ -0,0 +1,85 @@
+import pytest
+
+
+solr_config = {
+    "fieldList": [
+        "UID",
+        "Title",
+        "Description",
+        "Type",
+        "effective",
+        "start",
+        "created",
+        "end",
+        "path_string",
+        "phone",
+        "email",
+        "location",
+    ],
+    "searchTabs": [
+        {
+            "label": "All except Pages",
+            "filter": "-Type:(Page)",
+        },
+        {
+            "label": "Pages",
+            "filter": "Type:(Page)",
+        },
+        {
+            "label": "News Items",
+            "filter": 'Type:("News Item")',
+        },
+        {
+            "label": "Pages and News Items",
+            "filter": 'Type:(Page OR "News Item")',
+        },
+    ],
+}
+
+
+@pytest.fixture()
+def registry_config() -> dict:
+    """Override registry configuration."""
+    return {
+        "collective.solr.active": 1,
+        "kitconcept.solr.config": solr_config,
+    }
+
+
+class TestEndpointFirstTab:
+    @pytest.fixture(autouse=True)
+    def _init(self, portal_with_content, manager_request):
+        self.portal = portal_with_content
+        response = manager_request.get(self.url)
+        self.data = response.json()
+
+
+class TestEndpointFirstTabBaseSearch(TestEndpointFirstTab):
+    url = "/@solr?q=chomsky"
+
+    def test_facet_groups(self):
+        # Using default configuration
+        assert "response" in self.data
+        assert self.data.get("facet_groups") == [
+            ["All except Pages", 2],
+            ["Pages", 1],
+            ["News Items", 1],
+            ["Pages and News Items", 2],
+        ]
+
+    @pytest.mark.parametrize(
+        "path,expected",
+        [
+            ("/plone/mydocument", False),
+            ("/plone/noamchomsky", True),
+            ("/plone/mynews", True),
+        ],
+    )
+    def test_paths(self, all_path_string, path: str, expected: bool):
+        path_strings = all_path_string(self.data)
+        assert (path in path_strings) is expected
+
+    def test_portal_path(self):
+        """portal_path is returned for the client"""
+        assert "response" in self.data
+        assert self.data.get("portal_path") == "/plone"