Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation #1

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

First implementation #1

wants to merge 21 commits into from

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested review from davisagli and ericof April 16, 2024 21:44
Dockerfile.builder Outdated Show resolved Hide resolved
Dockerfile.builder Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@davisagli
Copy link
Member

I really don't like including the full volto repository clone in the image.

Dockerfile.builder Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

davisagli commented Apr 19, 2024

The new images are a lot bigger than the existing ones. We need to do better.

Image Size (existing image) Size (image from this PR)
dev 803 MB 2.89 GB
prod 237 MB 1.62 GB

@davisagli
Copy link
Member

@sneridagh I did some work on optimizing the production image in this branch: https://github.com/kitconcept/plone-frontend/compare/newapproach...newapproach-davisagli?expand=1

There is more that can be done, by avoiding a full clone of the volto repository.

Copy link

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @davisagli suggestions. About cookieplone, on Monday I will implement a hidden variable to not generate the volto addon

@sneridagh
Copy link
Member Author

@davisagli I merged your branch into here. I will improve the git command for the checkout.

@sneridagh
Copy link
Member Author

sneridagh commented May 16, 2024

@davisagli the prod image is down to 1GB, while the current one is 1.68GB:

REPOSITORY                                       TAG               IMAGE ID       CREATED          SIZE
ghcr.io/kitconcept/plone-frontend                18.0.0-alpha.31   f2732e3cfe09   10 minutes ago   1.03GB
ghcr.io/kitconcept/frontend-prod-config          18.0.0-alpha.31   4f2941fa48eb   11 minutes ago   473MB
ghcr.io/kitconcept/frontend-builder              18.0.0-alpha.31   7f55a35d4569   22 minutes ago   3.53GB
plone/plone-frontend                             18.0.0-alpha.31   43b2e5a46302   14 hours ago     1.68GB

BTW, where did you get the numbers in your previous comment? Look at the current image ones...

@davisagli
Copy link
Member

Here's my attempt to update the official plone-frontend image to make both the old and new approaches available: plone/plone-frontend#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants