Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with the Volto 17 Image component #28

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Sep 19, 2023

Upgraded also the add-on dockerized environment.
Upgraded to use Volto 17

@sneridagh sneridagh requested a review from davisagli September 19, 2023 16:36
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh linting and acceptance tests failed

(openExternalLinkInNewTab && !isInternalURL(href['@id']))
? '_blank'
: null
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be mentioned in the release notes too

@sneridagh sneridagh merged commit e0928d8 into main Sep 20, 2023
4 checks passed
@sneridagh sneridagh deleted the sliderusesnewimagecomponent branch September 20, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants