Allow for slides with no href PoC

locales/ca/LC_MESSAGES/volto.po

@@ -23,6 +23,11 @@ msgstr ""
 msgid "Add item"
 msgstr "Afegir element"
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -33,16 +38,6 @@ msgstr "Descripció"
 msgid "Go to slide"
 msgstr "Vés a slide"
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr "Títol de capçalera"
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr "Imatge"
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -53,16 +48,21 @@ msgstr "Element"
 msgid "Items"
 msgstr "Elements"
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr "Següent slide"
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
-msgstr "Si us plau, escolleixi un contingut existent per aquest element"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
+msgstr ""
 
 #: components/DotsAndArrows
 # defaultMessage: Previous slide

locales/de/LC_MESSAGES/volto.po

@@ -21,6 +21,11 @@ msgstr ""
 msgid "Add item"
 msgstr "Element hinzufügen"
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -31,16 +36,6 @@ msgstr "Beschreibung"
 msgid "Go to slide"
 msgstr "Gehe zu Slide"
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr "Kopftitel"
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr "Bild überschreiben"
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -51,16 +46,21 @@ msgstr "Element"
 msgid "Items"
 msgstr "Elemente"
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr "Nächster Slide"
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
-msgstr "Bitte wählen sie einen existierenden Inhalt als Quelle für dieses Element aus"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
+msgstr ""
 
 #: components/DotsAndArrows
 # defaultMessage: Previous slide

locales/en/LC_MESSAGES/volto.po

@@ -16,6 +16,11 @@ msgstr ""
 msgid "Add item"
 msgstr ""
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -26,16 +31,6 @@ msgstr ""
 msgid "Go to slide"
 msgstr ""
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr ""
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr ""
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -46,15 +41,20 @@ msgstr ""
 msgid "Items"
 msgstr ""
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr ""
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
 msgstr ""
 
 #: components/DotsAndArrows

locales/es/LC_MESSAGES/volto.po

@@ -25,6 +25,11 @@ msgstr ""
 msgid "Add item"
 msgstr "Añadir elemento"
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -35,16 +40,6 @@ msgstr "Descripción"
 msgid "Go to slide"
 msgstr "Ver slide"
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr "Título principal"
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr "Sobre-escritura de imagen"
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -55,16 +50,21 @@ msgstr "Elemento"
 msgid "Items"
 msgstr "Elementos"
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr "Siguiente slide"
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
-msgstr "Elija un contenido existente como fuente para este elemento"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
+msgstr ""
 
 #: components/DotsAndArrows
 # defaultMessage: Previous slide

locales/nl/LC_MESSAGES/volto.po

@@ -20,6 +20,11 @@ msgstr ""
 msgid "Add item"
 msgstr "Item toevoegen"
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -30,16 +35,6 @@ msgstr "Omschrijving"
 msgid "Go to slide"
 msgstr ""
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr "Kop"
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr "Afbeelding overschrijven"
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -50,16 +45,21 @@ msgstr "Item"
 msgid "Items"
 msgstr "Items"
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr ""
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
-msgstr "Kies een bestaand item als bron voor dit element"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
+msgstr ""
 
 #: components/DotsAndArrows
 # defaultMessage: Previous slide

locales/volto.pot

@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: Plone\n"
-"POT-Creation-Date: 2023-12-14T11:35:27.943Z\n"
+"POT-Creation-Date: 2024-01-15T21:54:10.759Z\n"
 "Last-Translator: Plone i18n <[email protected]>\n"
 "Language-Team: Plone i18n <[email protected]>\n"
 "MIME-Version: 1.0\n"
@@ -18,6 +18,11 @@ msgstr ""
 msgid "Add item"
 msgstr ""
 
+#: components/schema
+# defaultMessage: Custom image
+msgid "Custom image"
+msgstr ""
+
 #: components/schema
 # defaultMessage: Description
 msgid "Description"
@@ -28,16 +33,6 @@ msgstr ""
 msgid "Go to slide"
 msgstr ""
 
-#: components/schema
-# defaultMessage: Headtitle
-msgid "Headtitle"
-msgstr ""
-
-#: components/schema
-# defaultMessage: Image override
-msgid "Image override"
-msgstr ""
-
 #: components/schema
 # defaultMessage: Item
 msgid "Item"
@@ -48,15 +43,20 @@ msgstr ""
 msgid "Items"
 msgstr ""
 
+#: components/schema
+# defaultMessage: Kicker
+msgid "Kicker"
+msgstr ""
+
 #: components/DotsAndArrows
 # defaultMessage: Next slide
 msgid "Next slide"
 msgstr ""
 
 #: components/DefaultBody
 #: components/View
-# defaultMessage: Please choose an existing content as source for this element
-msgid "Please choose an existing content as source for this element"
+# defaultMessage: Please choose an existing content as target for this element or select a custom image
+msgid "Please choose an existing content as target for this element or select a custom image"
 msgstr ""
 
 #: components/DotsAndArrows

news/42.feature

@@ -0,0 +1 @@
+Allow for slides to have no target link, as long as there is a custom image chosen. @danalvrz

src/components/DefaultBody.jsx

@@ -10,9 +10,9 @@ import config from '@plone/volto/registry';
 
 const messages = defineMessages({
   PleaseChooseContent: {
-    id: 'Please choose an existing content as source for this element',
+    id: 'Please choose an existing content as target for this element or select a custom image',
     defaultMessage:
-      'Please choose an existing content as source for this element',
+      'Please choose an existing content as target for this element or select a custom image',
   },
   moreInfo: {
     id: 'moreInfo',
@@ -67,11 +67,11 @@ const SliderBody = ({
   return (
     <div
       className={cx('grid-teaser-item top', {
-        'empty-slide': !href && isEditMode,
+        'empty-slide': !href && !image && isEditMode,
         'slide-visible': isActive,
       })}
     >
-      {!href && isEditMode && (
+      {!href && !image && isEditMode && (
         <Message>
           <div className="grid-teaser-item default">
             <img src={imageBlockSVG} alt="" />
@@ -91,12 +91,12 @@ const SliderBody = ({
           </div>
         </Message>
       )}
-      {href && (
+      {(href || image) && (
         <div className="teaser-item top">
           <MaybeWrap
-            condition={!isEditMode}
+            condition={!isEditMode && href}
             as={UniversalLink}
-            href={href['@id']}
+            href={href?.['@id']}
             target={
               data.openLinkInNewTab ||
               (openExternalLinkInNewTab && !isInternalURL(href['@id']))
@@ -105,7 +105,7 @@ const SliderBody = ({
             }
             tabIndex={!isActive ? '-1' : null}
           >
-            {(href?.hasPreviewImage || href.image_field || image) && (
+            {(href?.hasPreviewImage || href?.image_field || image) && (
               <div className="highlight-image-wrapper gradient">
                 <Image
                   item={image || href}

src/components/View.jsx

@@ -10,9 +10,9 @@ import teaserTemplate from '../icons/teaser-template.svg';
 
 const messages = defineMessages({
   PleaseChooseContent: {
-    id: 'Please choose an existing content as source for this element',
+    id: 'Please choose an existing content as target for this element or select a custom image',
     defaultMessage:
-      'Please choose an existing content as source for this element',
+      'Please choose an existing content as target for this element or select a custom image',
   },
 });